UseCorrectCasing: Do not correct applications or script paths at all #1255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #1206
When PowerShell starts at a directory and a script has an expression like the dot operator to a relative path that exists, Get-Command returns an object and makes it correct the path to the file name in the new UseCorrectCasing formatting rule (this rule is turned off by default in the vs code editor). We do not want to change paths at all (there could even be path casing issues if someone develops on Windows for example), therefore the exclusion applies. It was hard to write a test case for this but the same bug also occurs when using a UNC file path and this was chosen to be the test case for the written regression test.
In general we also found more edge cases of application paths being corrected as well and takie this logic out as well due to the time pressure of shipping 1.18.1 It seemed something easy for free at first but that was actually not the intent of the rule and it seems it is anon-trivial feature that someone might want to add later but not now.
PR Checklist
.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
to the beginning of the title and remove the prefix when the PR is ready.